Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Use Program instead of (Hash, Box<[u8]>) #1558

Merged
merged 4 commits into from
Aug 9, 2024
Merged

core: Use Program instead of (Hash, Box<[u8]>) #1558

merged 4 commits into from
Aug 9, 2024

Conversation

kim
Copy link
Contributor

@kim kim commented Jul 31, 2024

Refactor to use Program (introduced in #1532) throughout.

Also avoid cloning the program bytes to instantiate a wasm module.
This makes the AnyBytes type unused, so remove it.

API and ABI breaking changes

No

Expected complexity level and risk

1 -- mostly mechanical

Testing

n/a

Refactor to use `Program` (introduced in #1532) throughout.

Also avoid cloning the program bytes to instantiate a wasm module.
This makes the `AnyBytes` type unused, so remove it.
@kim kim requested a review from cloutiertyler as a code owner July 31, 2024 08:23
@kim kim added the release-any To be landed in any release window label Jul 31, 2024
@kim kim requested a review from Centril July 31, 2024 08:23
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the red numbers!

Co-authored-by: Mazdak Farrokhzad <[email protected]>
Signed-off-by: Kim Altintop <[email protected]>
@kim kim enabled auto-merge July 31, 2024 09:09
@Centril Centril requested a review from cloutiertyler August 6, 2024 13:18
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@kim kim added this pull request to the merge queue Aug 9, 2024
Merged via the queue into master with commit ba4546c Aug 9, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants