fix: windows: enable mouse mode on demand #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
requested review from
meowgorithm,
caarlos0,
raphamorim and
andreynering
aymanbagabas
force-pushed
the
windows-mouse-mode
branch
from
4ce34d0 to
2c37312
Compare
raphamorim
reviewed
Feb 24, 2025
raphamorim
reviewed
Feb 24, 2025
aymanbagabas
force-pushed
the
windows-mouse-mode
branch
from
2c37312 to
e14bd6c
Compare
Since we added native Windows API input events support, we always enable mouse events even if the user doesn't want them. This is a problem because it breaks applications that don't expect mouse events and selection stops working without any modifier key. Fixes: #1313
aymanbagabas
force-pushed
the
windows-mouse-mode
branch
from
e14bd6c to
ed6c89a
Compare
raphamorim
approved these changes
Feb 24, 2025
andreynering
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we added native Windows API input events support, we always enable mouse events even if the user doesn't want them. This is a problem because it breaks applications that don't expect mouse events and selection stops working without any modifier key.
See: https://learn.microsoft.com/en-us/windows/terminal/selection
Fixes: #1313