Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulley: Assert calling-conventions match instructions #9836

Closed
wants to merge 1 commit into from
Closed

pulley: Assert calling-conventions match instructions #9836

wants to merge 1 commit into from

Conversation

alexcrichton
Copy link
Member

Use the "tail" calling convention for pulley<->pulley calls and "systemv" is used for calling the host.

@alexcrichton
pulley: Assert calling-conventions match instructions
fa6c591 
Use the "tail" calling convention for pulley<->pulley calls and
"systemv" is used for calling the host.
@alexcrichton alexcrichton requested a review from a team as a code owner December 16, 2024 18:47
@alexcrichton alexcrichton requested review from abrown and removed request for a team December 16, 2024 18:47
@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Dec 16, 2024
@alexcrichton
Copy link
Member Author

Hm actually no this doesn't work because of *.clif filetests which aren't all using tail and systemv, so I'm going to close this.

@alexcrichton alexcrichton mentioned this pull request Dec 16, 2024
Closed
13 tasks
@alexcrichton alexcrichton deleted the pulley-call-assertions branch December 17, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrown abrown Awaiting requested review from abrown abrown is a code owner automatically assigned from bytecodealliance/wasmtime-compiler-reviewers

Assignees
No one assigned
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexcrichton