Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasmtime_instance_pre_instantiate should take a wasmtime_context_t #9770

Merged
merged 1 commit into from
Dec 9, 2024
Merged

wasmtime_instance_pre_instantiate should take a wasmtime_context_t #9770

merged 1 commit into from
Dec 9, 2024

Conversation

simonvik
Copy link
Contributor

@simonvik simonvik commented Dec 9, 2024

The current definition of wasmtime_instance_pre_instantiate takes a wasmtime_store_t but the rust-code seem to want a wasmtime_context_t.

@simonvik simonvik requested a review from a team as a code owner December 9, 2024 17:39
@simonvik simonvik requested review from alexcrichton and removed request for a team December 9, 2024 17:39
alexcrichton
alexcrichton approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Dec 9, 2024
Merged via the queue into bytecodealliance:main with commit 5dcaa13 Dec 9, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonvik @alexcrichton