winch: implement div for aarch64 #9762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
aarch-64-div
branch
from
6007f4e to
3e914eb
Compare
Subscribe to Label Action
This issue or pull request has been labeled: "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
MarinPostma
requested review from
cfallin and
alexcrichton
and removed request for
a team
cfallin
requested review from
saulecabrera
and removed request for
cfallin and
alexcrichton
|
passing review over to @saulecabrera if you don't mind! |
saulecabrera
reviewed
Dec 9, 2024
winch/codegen/src/isa/aarch64/asm.rs
Outdated
| }) | ||
| } | ||
|
|
||
| // cranelif-codegen doesn't support emitting u/sdiv for anything but I64, |
There was a problem hiding this comment.
Suggested change
| // cranelif-codegen doesn't support emitting u/sdiv for anything but I64, | |
| // `cranelift-codegen` doesn't support emitting u/sdiv for anything but I64, |
There was a problem hiding this comment.
Would you mind linking to this issue from this comment? #9766
winch/codegen/src/isa/aarch64/asm.rs
Outdated
| DivKind::Unsigned => ALUOp::UDiv, | ||
| }; | ||
|
|
||
| self.emit(Inst::AluRRR { |
There was a problem hiding this comment.
Here you can use the emit_alu_rrr helper defined in this file.
saulecabrera
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement integer division for arch64