Implement the array.copy Wasm GC instruction
#9389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also involved fixing some `VMGcRef` initialization and GC barrier code for globals. That in turn involved making global initialization fallible, which meant that it needed to be pulled out of `vmctx` initialization and put into instance initialization. Co-Authored-By: Alex Crichton <[email protected]>
alexcrichton
approved these changes
Oct 7, 2024
crates/wasmtime/src/runtime/vm/gc.rs
Outdated
Comment on lines
109
to
110
| destination.write(None); | ||
| let destination = unsafe { destination.assume_init_mut() }; |
There was a problem hiding this comment.
Looks like MaybeUninit::write returns &mut T so I think this can be let destination = destination.write(None);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also involved fixing some
VMGcRefinitialization and GC barrier code for globals. That in turn involved making global initialization fallible, which meant that it needed to be pulled out ofvmctxinitialization and put into instance initialization.