Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement semver compatibility for exports #8830

Merged

Conversation

alexcrichton
Copy link
Member

This commit is an implementation of component model semver compatibility for export lookups. Previously in #7994 component imports were made semver-aware to ensure that bumping version numbers would not be a breaking change. This commit implements the same feature for component exports. This required some refactoring to move the definition of semver compat around and the previous refactoring in #8786 enables frontloading this work to happen before instantiation.

Closes #8395

This commit is an implementation of component model semver compatibility
for export lookups. Previously in bytecodealliance#7994 component imports were made
semver-aware to ensure that bumping version numbers would not be a
breaking change. This commit implements the same feature for component
exports. This required some refactoring to move the definition of semver
compat around and the previous refactoring in bytecodealliance#8786 enables frontloading
this work to happen before instantiation.

Closes bytecodealliance#8395
@alexcrichton alexcrichton requested review from a team as code owners June 18, 2024 01:42
@alexcrichton alexcrichton requested review from elliottt and removed request for a team June 18, 2024 01:42
@github-actions github-actions bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label Jun 18, 2024
Copy link
Member

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I had a few suggestions that you can take or leave :)

@alexcrichton alexcrichton enabled auto-merge June 18, 2024 17:34
@alexcrichton alexcrichton added this pull request to the merge queue Jun 18, 2024
Merged via the queue into bytecodealliance:main with commit 9bdb731 Jun 18, 2024
36 checks passed
@alexcrichton alexcrichton deleted the semver-compat-exports branch June 18, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WASI semver compatibility should apply to exports
2 participants