-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasmtime: generalize async_stack_zeroing
knob to cover initialization
#10027
Wasmtime: generalize async_stack_zeroing
knob to cover initialization
#10027
Conversation
This commit moves the knob from the `PoolingInstanceAllocatorConfig` to the regular `Config` and now controls both whether stacks are zeroed before reuse and whether they are zeroed before the initial use. The latter doesn't matter usually, since anonymous mmaps are already zeroed so we don't have to do anything there, but for no-std environments it is the difference between manually zeroing the stack or simply using unininitialized memory.
Label Messager: wasmtime:configIt looks like you are changing Wasmtime's configuration options. Make sure to
To modify this label's message, edit the To add new label messages or remove existing label messages, edit the |
Grabbing the latest patch release since it contains the latest fixes. This change also mirrors the `async_stack_zeroing` change, introduced in bytecodealliance/wasmtime#10027
* Bump wasmtime to v30.0.2 Grabbing the latest patch release since it contains the latest fixes. This change also mirrors the `async_stack_zeroing` change, introduced in bytecodealliance/wasmtime#10027 * Document `async_stack_zeroing` at the engine level * Update nightly version * Bump `yard-rustdoc` * Strip the nightly version after reading it To ensure no unwanted new lines or spaces are included as part of interpolation
This commit moves the knob from the
PoolingInstanceAllocatorConfig
to the regularConfig
and now controls both whether stacks are zeroed before reuse and whether they are zeroed before the initial use. The latter doesn't matter usually, since anonymous mmaps are already zeroed so we don't have to do anything there, but for no-std environments it is the difference between manually zeroing the stack or simply using unininitialized memory.