Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasmtime: generalize async_stack_zeroing knob to cover initialization #10027

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Jan 15, 2025

This commit moves the knob from the PoolingInstanceAllocatorConfig to the regular Config and now controls both whether stacks are zeroed before reuse and whether they are zeroed before the initial use. The latter doesn't matter usually, since anonymous mmaps are already zeroed so we don't have to do anything there, but for no-std environments it is the difference between manually zeroing the stack or simply using unininitialized memory.

This commit moves the knob from the `PoolingInstanceAllocatorConfig` to the
regular `Config` and now controls both whether stacks are zeroed before reuse
and whether they are zeroed before the initial use. The latter doesn't matter
usually, since anonymous mmaps are already zeroed so we don't have to do
anything there, but for no-std environments it is the difference between
manually zeroing the stack or simply using unininitialized memory.
@fitzgen fitzgen requested a review from a team as a code owner January 15, 2025 21:42
@fitzgen fitzgen requested review from alexcrichton and removed request for a team January 15, 2025 21:42
@fitzgen fitzgen enabled auto-merge January 15, 2025 22:12
@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

@fitzgen fitzgen requested a review from a team as a code owner January 16, 2025 00:08
@fitzgen fitzgen added this pull request to the merge queue Jan 16, 2025
Merged via the queue into bytecodealliance:main with commit 980a136 Jan 16, 2025
41 checks passed
@fitzgen fitzgen deleted the optional-stack-zeroing branch January 16, 2025 00:42
saulecabrera added a commit to bytecodealliance/wasmtime-rb that referenced this pull request Mar 3, 2025
Grabbing the latest patch release since it contains the latest fixes.

This change also mirrors the `async_stack_zeroing` change, introduced in
bytecodealliance/wasmtime#10027
saulecabrera added a commit to bytecodealliance/wasmtime-rb that referenced this pull request Mar 5, 2025
* Bump wasmtime to v30.0.2

Grabbing the latest patch release since it contains the latest fixes.

This change also mirrors the `async_stack_zeroing` change, introduced in
bytecodealliance/wasmtime#10027

* Document `async_stack_zeroing` at the engine level

* Update nightly version

* Bump `yard-rustdoc`

* Strip the nightly version after reading it

To ensure no unwanted new lines or spaces are included as part of
interpolation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants