Fix Wasm GC validation/generation of field types' mutability and subtyping #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously incorrectly treated the following invalid cases as valid: 1. mismatched mutable and immutable fields (mutability must match exactly) 2. mutable references to subtypes (mutable reference fields must be invariant)
Ensure that the mutability always matches and that mutable fields are invariant with respect to the field's storage type.
alexcrichton
approved these changes
Dec 3, 2024
fitzgen
added a commit
to fitzgen/wasmtime
that referenced
this pull request
Dec 3, 2024
Similar to bytecodealliance/wasm-tools#1934 but for `wasmtime::FieldType`.
github-merge-queue bot
pushed a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Dec 3, 2024
Similar to bytecodealliance/wasm-tools#1934 but for `wasmtime::FieldType`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.