-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make secret value rejection on pipeline upload optional #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd36e0c
to
684d9a5
Compare
moskyb
commented
Mar 22, 2022
ticky
approved these changes
Mar 22, 2022
pda
reviewed
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good plan 👍🏼
pda
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, up to you if you want to fix #1589 (comment)
50c34d3
to
bb17702
Compare
bb17702
to
99ce182
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Problem: In #1523, we made it so that the
buildkite-agent pipeline upload
command would reject any pipeline yaml that had sensitive values in it. We shipped this as part of v3.34. This is an awesome security feature, and prevents a bunch of footguns, but unfortunately it's a breaking change, and we accidentally shipped it as part of a minor release.✅ Solution: This PR reverts default redaction behaviour to how it was previously, with some slight changes:
--reject-secrets
flag--reject-secrets
flag isn't used, the command issues a warning that:Slightly related, it makes the
--dry-run
flag for the pipeline upload command work with redaction.Screenshots:
Without
--reject-secrets
:With
--reject-secrets
:These are from my local machine using the
--dry-run
flag, using this pipeline:Closes #1578
Closes PIP-309