Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit a scalar type for T in iter.SQL #15

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Permit a scalar type for T in iter.SQL #15

merged 1 commit into from
Jul 7, 2024

Conversation

bobg
Copy link
Owner

@bobg bobg commented Jul 7, 2024

This PR expands iter.SQL, permitting its type parameter optionally to be a scalar instead of a struct, in the case where the db query produces a single value per row.

@bobg bobg marked this pull request as ready for review July 7, 2024 01:41
Copy link

github-actions bot commented Jul 7, 2024

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR requires (at least) an increase in your module's patchlevel.

checking keyedSorter
  old and new versions of github.com/bobg/go-generics/v3/slices.keyedSorter[S ~[]T, T any] are not identical
    Patchlevel

@coveralls
Copy link

coveralls commented Jul 7, 2024

Pull Request Test Coverage Report for Build 9823633326

Details

  • 18 of 22 (81.82%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 87.854%

Changes Missing Coverage Covered Lines Changed/Added Lines %
iter/sql.go 18 22 81.82%
Totals Coverage Status
Change from base Build 9142844186: -0.2%
Covered Lines: 1056
Relevant Lines: 1202

💛 - Coveralls

@bobg bobg merged commit 2cd7a2b into master Jul 7, 2024
2 checks passed
@bobg bobg deleted the bobg/sql-scalar branch July 7, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants