Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Number.prototype.toExponential() #50

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Implement Number.prototype.toExponential() #50

wants to merge 1 commit into from

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Feb 24, 2025 •
edited
Loading

This Pull Request fixes/closes #31

This is very WIP but the failing test262 test in the Number suite is fixed 🥳 , still have to do a lot more testing to make sure that it's sound.

It changes the following:

  • Implements Number.prototype.toExponential(precision)
  • Add failing test262 test.

TODO

  • Implement case when precision is undefined
  • Add more edge case tests
  • Partially compute table at runtime to avoid binary bloat.

@HalidOdat HalidOdat added the enhancement New feature or request label Feb 24, 2025
@HalidOdat HalidOdat added this to the v1.1.0 milestone Feb 24, 2025
@HalidOdat HalidOdat changed the title Initial implementation Implement Number.prototype.toExponential() Feb 24, 2025
@HalidOdat HalidOdat marked this pull request as draft February 24, 2025 21:49
@HalidOdat HalidOdat mentioned this pull request Feb 24, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Implement Number.prototype.toExponential()
1 participant
@HalidOdat