Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporal bump and fixes #4193

Merged
merged 7 commits into from
Mar 1, 2025
Merged

Temporal bump and fixes #4193

merged 7 commits into from
Mar 1, 2025

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Mar 1, 2025

This Pull Request related to ongoing work for #1804

It changes the following:

  • Bumps temporal_rs and related fixes
  • Adds ZonedDateTime::round stub that was somehow missed.
  • A couple fixes for PlainDate order of operations and instant
  • A bump to tinystr that was causing package resolution issues.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2025 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 46,559 46,615 +56
Ignored 1,634 1,634 0
Failed 2,061 2,005 -56
Panics 0 0 0
Conformance 92.65% 92.76% +0.11%
Fixed tests (59): 
test/built-ins/Temporal/PlainDate/prototype/until/largestunit-default.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/smallestunit-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/timezone-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/largestunit-default.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/smallestunit-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/order-of-operations.js (previously Failed)
test/built-ins/Temporal/Now/zonedDateTimeISO/timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/Now/zonedDateTimeISO/timezone-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/Now/plainDateISO/timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/Now/plainDateISO/timezone-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/Now/plainDateTimeISO/timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/Now/plainDateTimeISO/timezone-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/Now/plainTimeISO/timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/Now/plainTimeISO/timezone-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-timezone-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-timezone-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/builtin.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toJSON/year-format.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/epochMilliseconds/basic.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainDateTime/limits.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-timezone-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/until/defaults-to-returning-hours.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/until/argument-propertybag-timezone-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/until/order-of-operations.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/until/argument-propertybag-timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/timezone-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/since/defaults-to-returning-hours.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/since/argument-propertybag-timezone-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/since/order-of-operations.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/since/argument-propertybag-timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toString/year-format.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/returns-days.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/returns-days.js (previously Failed)
test/built-ins/Temporal/Instant/compare/length.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/toZonedDateTimeISO/timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/toZonedDateTimeISO/timezone-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/toJSON/year-format.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/epochMilliseconds/basic.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/smallestunit-invalid-string.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/smallestunit-invalid-string.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/toString/year-format.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/toString/timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/toString/timezone-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/Duration/compare/relativeto-propertybag-timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/relativeto-propertybag-timezone-string-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/smallestunit-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/smallestunit-invalid-string.js (previously Failed)
Broken tests (3): 
test/built-ins/Temporal/ZonedDateTime/prototype/round/throws-without-parameter.js (previously Passed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/options-wrong-type.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/round/next-day-out-of-range.js (previously Passed)

@nekevss
Copy link
Member Author

nekevss commented Mar 1, 2025

Broken tests are a regression from an upstream change. I'll submit a fix for it ASAP.

@nekevss nekevss mentioned this pull request Mar 1, 2025
Merged
jedel1043 pushed a commit to boa-dev/temporal that referenced this pull request Mar 1, 2025
@nekevss
Fix not adjusting fraction for duration unit (#228)
ed7c1af 
Fix for the regression showing up on boa-dev/boa#4193.

During the last update, I forgot that fraction is now agnostic about
it's unit, so it needs to be adjusted for the unit.
@nekevss
Copy link
Member Author

nekevss commented Mar 1, 2025 •
edited
Loading

General notes on the remaining broken tests (I'll update as I go):

Test:
test/built-ins/Temporal/ZonedDateTime/prototype/round/throws-without-parameter.js (previously Passed)
Note: Should be a false positive. Just added the stub for round in this PR.

Test
test/built-ins/Temporal/ZonedDateTime/prototype/round/options-wrong-type.js (previously Passed)
Note: Should be a false positive. Just added the stub for round in this PR.

Test:
test/built-ins/Temporal/PlainDateTime/from/argument-string-subsecond.js (previously Passed)
Note: Regression -> submitting PR for fix boa-dev/temporal#229

Test:
test/built-ins/Temporal/Duration/prototype/round/next-day-out-of-range.js (previously Passed)
Note: High level of confidence this is a false positive. (going to involve addressing updating Duration::round)

@nekevss nekevss requested a review from jedel1043 March 1, 2025 18:09
jedel1043
jedel1043 approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jedel1043 jedel1043 added this pull request to the merge queue Mar 1, 2025
Merged via the queue into main with commit 4e31c15 Mar 1, 2025
14 checks passed
@jedel1043 jedel1043 deleted the temporal-bump-and-fixes branch March 1, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nekevss @jedel1043