Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cleanup + order of operations fixes #4190

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Feb 26, 2025

This Pull Request related to ongoing work for #1804.

It changes the following:

  • Fixes the order of operations for to_partial_zdt
  • Removes some unused code

Copy link

github-actions bot commented Feb 26, 2025

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 46,451 46,559 +108
Ignored 1,634 1,634 0
Failed 2,169 2,061 -108
Panics 0 0 0
Conformance 92.43% 92.65% +0.21%
Fixed tests (108):
test/intl402/Temporal/Duration/compare/relativeto-hour.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/monthcode-invalid.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/monthcode-invalid.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/order-of-operations.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/monthcode-invalid.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/offset-timezone-no-transitions.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/direction-undefined.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/direction-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/wrong-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/order-of-operations.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/limits.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/basic.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-object.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/limits.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/options-undefined.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/reference-day.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/monthcode-invalid.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/overflow-undefined.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-leap-second.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-plaindate.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/overflow-constrain.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/options-object.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/overflow-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-iso-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/one-of-era-erayear-undefined.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-string-limits.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/with/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-propertybag-calendar-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-propertybag-calendar-leap-second.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-propertybag-calendar-iso-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-cast.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-string-limits.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/add/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/add/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/add/argument-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/limits.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/argument-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-propertybag-calendar-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-propertybag-calendar-leap-second.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-propertybag-calendar-iso-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-cast.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-string-limits.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/monthcode-invalid.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/order-of-operations.js (previously Failed)
test/built-ins/Temporal/Duration/compare/relativeto-propertybag-timezone-string-leap-second.js (previously Failed)
test/built-ins/Temporal/Duration/compare/duration-out-of-range-added-to-relativeto.js (previously Failed)
test/built-ins/Temporal/Duration/compare/basic.js (previously Failed)
test/built-ins/Temporal/Duration/compare/relativeto-string-zoneddatetime-wrong-offset.js (previously Failed)
test/built-ins/Temporal/Duration/compare/relativeto-plaindate-add24hourdaystonormalizedtimeduration-out-of-range.js (previously Failed)
test/built-ins/Temporal/Duration/compare/relativeto-string-invalid.js (previously Failed)
test/built-ins/Temporal/Duration/compare/exhaustive.js (previously Failed)
test/built-ins/Temporal/Duration/compare/relativeto-propertybag-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Duration/compare/options-undefined.js (previously Failed)
test/built-ins/Temporal/Duration/compare/argument-string-fractional-units-rounding-mode.js (previously Failed)
test/built-ins/Temporal/Duration/compare/relativeto-propertybag-invalid-offset-string.js (previously Failed)
test/built-ins/Temporal/Duration/compare/argument-duration-out-of-range.js (previously Failed)
test/built-ins/Temporal/Duration/compare/argument-duration-precision-exact-numerical-values.js (previously Failed)
test/built-ins/Temporal/Duration/compare/calendar-possibly-required.js (previously Failed)
test/built-ins/Temporal/Duration/compare/order-of-operations.js (previously Failed)
test/built-ins/Temporal/Duration/compare/relativeto-month.js (previously Failed)
test/built-ins/Temporal/Duration/compare/relativeto-string-zoneddatetime.js (previously Failed)
test/built-ins/Temporal/Duration/compare/prop-desc.js (previously Failed)
test/built-ins/Temporal/Duration/compare/relativeto-undefined-throw-on-calendar-units.js (previously Failed)
test/built-ins/Temporal/Duration/compare/length.js (previously Failed)
test/built-ins/Temporal/Duration/compare/relativeto-hour.js (previously Failed)
test/built-ins/Temporal/Duration/compare/options-object.js (previously Failed)
test/built-ins/Temporal/Duration/compare/relativeto-zoneddatetime-negative-epochnanoseconds.js (previously Failed)
test/built-ins/Temporal/Duration/compare/instances-identical.js (previously Failed)
test/built-ins/Temporal/Duration/compare/relativeto-string-plaindatetime.js (previously Failed)
test/built-ins/Temporal/Duration/compare/argument-cast.js (previously Failed)
test/built-ins/Temporal/Duration/compare/name.js (previously Failed)
test/built-ins/Temporal/Duration/compare/compare-no-precision-loss.js (previously Failed)
test/built-ins/Temporal/Duration/compare/builtin.js (previously Failed)
test/built-ins/Temporal/Duration/compare/relativeto-propertybag-timezone-wrong-type.js (previously Failed)
test/built-ins/Temporal/Duration/compare/relativeto-year.js (previously Failed)
test/built-ins/Temporal/Duration/compare/year-zero.js (previously Failed)
test/built-ins/Temporal/Duration/compare/argument-string-negative-fractional-units.js (previously Failed)
test/built-ins/Temporal/Duration/compare/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/Duration/compare/argument-duration-max.js (previously Failed)
test/built-ins/Temporal/Duration/compare/relativeto-propertybag-timezone-string.js (previously Failed)
test/built-ins/Temporal/Duration/compare/calendar-temporal-object.js (previously Failed)
test/staging/sm/Temporal/PlainDate/from-hebrew-keviah.js (previously Failed)

@nekevss nekevss requested a review from a team February 26, 2025 23:30
@nekevss nekevss added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Feb 26, 2025
@raskad raskad requested a review from a team February 26, 2025 23:52
@jedel1043
Copy link
Member

@raskad as an FYI, we don't require two reviews to merge small PRs like this anymore (discussed this on yesterday's call), so you can merge as it is :)

@jedel1043 jedel1043 added this to the next-release milestone Feb 27, 2025
@jedel1043 jedel1043 added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit fd45665 Feb 27, 2025
14 checks passed
@jedel1043 jedel1043 deleted the relative-to-cleanup branch February 27, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants