Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize drop of common types for nan-boxed JsValue #4178

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

HalidOdat
Copy link
Member

This is a small optimization on of the drop method on nan-boxed values, rearrange the checks so the common pointer types get checked first. Since this method is called so many times this leads to some performance improvements.

Benchmarks

Main

PROGRESS Richards
RESULT Richards 123
PROGRESS DeltaBlue
RESULT DeltaBlue 111
PROGRESS Encrypt
PROGRESS Decrypt
RESULT Crypto 142
PROGRESS RayTrace
RESULT RayTrace 290
PROGRESS Earley
PROGRESS Boyer
RESULT EarleyBoyer 356
PROGRESS RegExp
RESULT RegExp 70.2
PROGRESS Splay
RESULT Splay 474
PROGRESS NavierStokes
RESULT NavierStokes 335
SCORE 197

PR

PROGRESS Richards
RESULT Richards 128
PROGRESS DeltaBlue
RESULT DeltaBlue 111
PROGRESS Encrypt
PROGRESS Decrypt
RESULT Crypto 149
PROGRESS RayTrace
RESULT RayTrace 292
PROGRESS Earley
PROGRESS Boyer
RESULT EarleyBoyer 364
PROGRESS RegExp
RESULT RegExp 71.1
PROGRESS Splay
RESULT Splay 474
PROGRESS NavierStokes
RESULT NavierStokes 347
SCORE 201

@HalidOdat HalidOdat added the performance Performance related changes and issues label Feb 25, 2025
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 46,451 46,451 0
Ignored 1,634 1,634 0
Failed 2,169 2,169 0
Panics 0 0 0
Conformance 92.43% 92.43% 0.00%

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jedel1043 jedel1043 added this to the next-release milestone Feb 26, 2025
@jedel1043 jedel1043 added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit 0efd651 Feb 26, 2025
14 checks passed
@jedel1043 jedel1043 deleted the optimization/prioritize-common-value-type-drop branch February 26, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related changes and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants