Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes from YearMonth parsing update and MonthCode addition #4173

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Feb 24, 2025

This Pull Request is related to ongoing work for #1804 and primarily #4077

It changes the following:

  • Includes PlainYearMonth::from_str fixes from temporal_rs
  • Includes updates related to MonthCode

Copy link

github-actions bot commented Feb 24, 2025

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 46,451 46,517 +66
Ignored 1,634 1,634 0
Failed 2,169 2,103 -66
Panics 0 0 0
Conformance 92.43% 92.56% +0.13%
Fixed tests (66):
test/built-ins/Temporal/PlainDateTime/from/monthcode-invalid.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/monthcode-invalid.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/monthcode-invalid.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/offset-timezone-no-transitions.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/direction-undefined.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/direction-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/wrong-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/limits.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/basic.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-object.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/limits.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/options-undefined.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/reference-day.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/monthcode-invalid.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/overflow-undefined.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-leap-second.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-plaindate.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/overflow-constrain.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/options-object.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/overflow-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-iso-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/one-of-era-erayear-undefined.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-string-limits.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/with/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-propertybag-calendar-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-propertybag-calendar-leap-second.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-propertybag-calendar-iso-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-cast.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-string-limits.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/add/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/add/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/add/argument-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/limits.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/argument-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-propertybag-calendar-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-propertybag-calendar-leap-second.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-propertybag-calendar-iso-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-cast.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-string-limits.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/monthcode-invalid.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-string-invalid.js (previously Failed)
test/staging/sm/Temporal/PlainDate/from-hebrew-keviah.js (previously Failed)

@jedel1043 jedel1043 added the builtins PRs and Issues related to builtins/intrinsics label Feb 24, 2025
@jedel1043 jedel1043 added this to the next-release milestone Feb 24, 2025
@nekevss nekevss requested a review from a team February 24, 2025 03:11
@raskad raskad requested a review from a team February 24, 2025 22:15
@jedel1043
Copy link
Member

Should probably bump again? I think we have more breaking changes in the queue.

@nekevss
Copy link
Member Author

nekevss commented Feb 25, 2025

Yeah, I can try and get a bump in on this PR later 🙃

@nekevss nekevss added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit 58ed9db Feb 26, 2025
14 checks passed
@nekevss nekevss deleted the integrate-ym-and-monthcode branch February 26, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants