Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some engine specific bugs and bump version #4167

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Feb 20, 2025

This Pull Request related to ongoing work for #1804.

It changes the following:

  • Adds a missing overflow check in to_zoneddatetime
  • Changes order of operations for PlainYearMonth method
  • Bumps temporal_rs to include more fixes

Copy link

github-actions bot commented Feb 20, 2025

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 46,261 46,324 +63
Ignored 1,634 1,634 0
Failed 2,359 2,296 -63
Panics 0 0 0
Conformance 92.05% 92.18% +0.13%
Fixed tests (63):
test/built-ins/Temporal/PlainDateTime/from/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/throws-argument-object-insufficient-data.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/throws-argument-object.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/one-of-era-erayear-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-string-leap-second.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/leap-second.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/overflow-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/observable-get-overflow-argument-primitive.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/overflow-invalid-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/until/leap-second.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/leap-second.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/since/leap-second.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/leap-second.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/leap-second.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/missing-properties.js (previously Failed)
test/built-ins/Temporal/Instant/from/leap-second.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/leap-second.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/leap-second.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/equals/leap-second.js (previously Failed)
test/built-ins/Temporal/Instant/compare/leap-second.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/relativeTo-required-properties.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/relativeto-wrong-type.js (previously Failed)

@nekevss nekevss requested a review from a team February 20, 2025 04:29
@nekevss
Copy link
Member Author

nekevss commented Feb 20, 2025

The broken tests are fixed by boa-dev/temporal#200. It would be great if that could be merged and bumped in this PR just to double check, but either way the tests should be fixed in the process.

jedel1043 pushed a commit to boa-dev/temporal that referenced this pull request Feb 20, 2025
@nekevss nekevss requested a review from a team February 20, 2025 15:22
@jedel1043 jedel1043 added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit aef159e Feb 20, 2025
14 checks passed
@jedel1043 jedel1043 deleted the bump-and-fixes branch February 20, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants