Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary calls of to_string in cow_* #4166

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

CrazyboyQCD
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 52.95%. Comparing base (6ddc2b4) to head (7a1108b).
Report is 375 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/builtins/string/mod.rs 0.00% 7 Missing ⚠️
core/engine/src/builtins/number/mod.rs 75.00% 1 Missing ⚠️
.../engine/src/builtins/temporal/zoneddatetime/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4166      +/-   ##
==========================================
+ Coverage   47.24%   52.95%   +5.71%     
==========================================
  Files         476      488      +12     
  Lines       46892    52472    +5580     
==========================================
+ Hits        22154    27789    +5635     
+ Misses      24738    24683      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jedel1043 jedel1043 added the Internal Category for changelog label Feb 19, 2025
@jedel1043 jedel1043 added this to the next-release milestone Feb 19, 2025
@jedel1043 jedel1043 requested a review from a team February 19, 2025 05:37
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nekevss nekevss added this pull request to the merge queue Feb 19, 2025
Merged via the queue into boa-dev:main with commit 677fd93 Feb 19, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants