Bump MSRV to 1.84 (#4165)

.github/workflows/rust.yml

@@ -38,10 +38,6 @@ jobs:
 
       - name: Install Rust toolchain
         uses: dtolnay/rust-toolchain@stable
-        with:
-          # TODO: There seems to be an issue with the 1.83.0 toolchain and tarpaulin.
-          #       See: https://github.com/xd009642/tarpaulin/issues/1642
-          toolchain: 1.82.0
 
       - uses: Swatinem/rust-cache@v2
         with:

Cargo.toml

@@ -24,7 +24,7 @@ exclude = [
 [workspace.package]
 edition = "2021"
 version = "0.20.0"
-rust-version = "1.82.0"
+rust-version = "1.84.0"
 authors = ["boa-dev"]
 repository = "https://github.com/boa-dev/boa"
 license = "Unlicense OR MIT"
@@ -95,8 +95,6 @@ syn = { version = "2.0.98", default-features = false }
 proc-macro2 = "1.0"
 synstructure = "0.13"
 measureme = "12.0.1"
-# TODO: when moving past 1.84, remove dependency to sptr and use `.addr()` directly.
-sptr = "0.3.2"
 paste = "1.0"
 rand = "0.9.0"
 num-integer = "0.1.46"

core/engine/Cargo.toml

@@ -91,7 +91,7 @@ ryu-js.workspace = true
 fast-float2.workspace = true
 once_cell = { workspace = true, features = ["std"] }
 tap.workspace = true
-sptr.workspace = true
+
 thiserror.workspace = true
 dashmap.workspace = true
 num_enum.workspace = true

core/engine/src/builtins/array_buffer/shared.rs

@@ -1,5 +1,3 @@
-#![allow(unstable_name_collisions)]
-
 use std::{
     alloc,
     sync::{atomic::Ordering, Arc},
@@ -610,7 +608,7 @@ pub(crate) fn create_shared_byte_data_block(
     // This could be replaced with a custom `Box` implementation, but most architectures
     // already align pointers to 8 bytes, so it's a lot of work for such a small
     // compatibility improvement.
-    assert_eq!(sptr::Strict::addr(buffer.as_ptr()) % align_of::<u64>(), 0);
+    assert_eq!(buffer.as_ptr().addr() % align_of::<u64>(), 0);
 
     // 3. Return db.
     Ok(buffer)

core/engine/src/builtins/array_buffer/utils.rs

@@ -1,5 +1,3 @@
-#![allow(unstable_name_collisions)]
-
 use std::{ptr, slice::SliceIndex, sync::atomic::Ordering};
 
 use portable_atomic::AtomicU8;
@@ -55,8 +53,8 @@ impl SliceRef<'_> {
     #[cfg(debug_assertions)]
     pub(crate) fn addr(&self) -> usize {
         match self {
-            Self::Slice(buf) => sptr::Strict::addr(buf.as_ptr()),
-            Self::AtomicSlice(buf) => sptr::Strict::addr(buf.as_ptr()),
+            Self::Slice(buf) => buf.as_ptr().addr(),
+            Self::AtomicSlice(buf) => buf.as_ptr().addr(),
         }
     }
 
@@ -242,8 +240,8 @@ impl SliceRefMut<'_> {
     #[cfg(debug_assertions)]
     pub(crate) fn addr(&self) -> usize {
         match self {
-            Self::Slice(buf) => sptr::Strict::addr(buf.as_ptr()),
-            Self::AtomicSlice(buf) => sptr::Strict::addr(buf.as_ptr()),
+            Self::Slice(buf) => buf.as_ptr().addr(),
+            Self::AtomicSlice(buf) => buf.as_ptr().addr(),
         }
     }