Report an error when running into i/o errors #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjbvr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of silently swallowing i/o errors when iterating over invalid directories, cargo-machete will now try its best at analyzing every directory it can, and then report an error at the end of the program's execution indicating the i/o errors. It's better in my opinion than the previous behavior, since now there's no way to miss i/o errors (or other issues like #62).
I'm curious if people would prefer to have this behavior be dynamically enabled via a CLI flag (
--fail-io-errors) because they have such use cases that i/o errors are unavoidable, or if that change is fine per se.