Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a docker image? #93

Closed
dessalines opened this issue Oct 26, 2023 · 4 comments · Fixed by #121
Closed

Create a docker image? #93

dessalines opened this issue Oct 26, 2023 · 4 comments · Fixed by #121

Comments

@dessalines
Copy link

It'd be really useful to have an official docker image along with your releases, that we could use in our CI pipeline.

@bnjbvr
Copy link
Owner

bnjbvr commented Oct 26, 2023

Sure, why not! If there's a way to automate that for free, using Github Actions for publishing the new image, I'm up for it. As I don't know too much how that all works, help would be appreciated.

@dessalines
Copy link
Author

I'm not familiar with github CI unfortunately, we use woodpecker CI which is an open source one for all our projects, and it has a docker buildx plugin that can build and push to dockerhub.

I'm sure one probably exists for github tho.

@dessalines
Copy link
Author

I've decided for things like this, rather than deploying a full docker image, its probably just easier to use cargo binstall in the CI. Here's some sample CI code:

commands:

- wget https://github.com/cargo-bins/cargo-binstall/releases/latest/download/cargo-binstall-x86_64-unknown-linux-musl.tgz
- tar -xvf cargo-binstall-x86_64-unknown-linux-musl.tgz
- cp cargo-binstall /usr/local/cargo/bin
- cargo binstall -y cargo-machete
- cargo machete

@dessalines dessalines closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
@bnjbvr
Copy link
Owner

bnjbvr commented Nov 1, 2023

Nice! TIL binstall. For what it's worth, one might also take the latest release exe from Github, modify it to make it executable, and then put it in $HOME/.cargo/bin, then run cargo machete.

bnjbvr pushed a commit that referenced this issue May 31, 2024
Fixes #93

I have already tested the code of this Pull Request in my own namespace. For details, please see this URL: https://github.com/DCjanus/cargo-machete/pkgs/container/cargo-machete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants