[PM-17901] Replaced hard-coded Bitwarden Vault URLs

[amorask-bitwarden]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17901

📔 Objective

There were several cases where we had the .com Bitwarden Vault URL hard-coded in our email templates. This PR resolves those according to the requirements in the ticket's "How do we fix it?" section.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 44.45%. Comparing base (1efc105) to head (1362b60).

Files with missing lines	Patch %	Lines
.../Services/Implementations/HandlebarsMailService.cs	0.00%	9 Missing ⚠️
...odels/Mail/OrganizationSeatsAutoscaledViewModel.cs	0.00%	1 Missing ⚠️
...odels/Mail/OrganizationSeatsMaxReachedViewModel.cs	0.00%	1 Missing ⚠️
.../OrganizationServiceAccountsMaxReachedViewModel.cs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5458      +/-   ##
==========================================
- Coverage   44.45%   44.45%   -0.01%     
==========================================
  Files        1530     1530              
  Lines       71002    71007       +5     
  Branches     6373     6374       +1     
==========================================
  Hits        31564    31564              
- Misses      38071    38076       +5     
  Partials     1367     1367              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jrmccannon]

Looks good. Just had a small question/suggestion. Non-blocking.

[github-actions]

Checkmarx One – Scan Summary & Details – 9ec3dada-4388-4906-921b-c0aaab6074f9

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	Log_Forging	/src/Api/Platform/Push/Controllers/PushController.cs: 76	details Method SendAsync at line 76 of /src/Api/Platform/Push/Controllers/PushController.cs gets user input from element model. This element’s value flows ... Attack Vector
	Unsafe_Use_Of_Target_blank	/src/Core/MailTemplates/Handlebars/OrganizationSeatsAutoscaled.html.hbs: 29	details Using <a href="{{{VaultSubscriptionUrl}}}" clicktracking=off target="_blank" style="color: #ffffff; text-decoration: none; text-align: center; curs... Attack Vector
	Unsafe_Use_Of_Target_blank	/src/Core/MailTemplates/Handlebars/OrganizationSeatsMaxReached.html.hbs: 27	details Using <a href="{{{VaultSubscriptionUrl}}}" clicktracking=off target="_blank" style="color: #ffffff; text-decoration: none; text-align: center; curs... Attack Vector

Fixed Issues (6)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CSRF	/src/Api/Controllers/CollectionsController.cs: 171
	CSRF	/src/Api/Controllers/CollectionsController.cs: 143
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 164
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 104
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 94
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud