Extend the password reprompt to the view cipher method. #13727
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #13727 +/- ##
=======================================
Coverage 35.95% 35.96%
=======================================
Files 3176 3176
Lines 93368 93370 +2
Branches 16962 16963 +1
=======================================
+ Hits 33573 33580 +7
+ Misses 57208 57203 -5
Partials 2587 2587 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
jprusik
approved these changes
Mar 6, 2025
|
Great job, no security vulnerabilities found in this Pull Request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-17022
📔 Objective
Viewing a cipher whether as a side effect of autofill or when clicking view cipher in the inline autofill menu should trigger the password reprompt when enabled for that cipher.
📸 Screenshots
Screen.Recording.2025-03-06.at.6.00.21.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes