fix: Two country typos #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biter777countries ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
While your change is legitimate, I'm a bit afraid about the effect of this breaking change So maybe the old const could be created at the end with a deprecated syntax Something like, your exact PR plus // Deprecated: CongoDemocracticRepublicCountryCode old const with a typo
CongoDemocracticRepublicCountryCode = CongoDemocracticRepublicCountryCodeThe deprecated comment is standard, gopls, so almost IDE handles it I'm not a maintainer, just a random gopher |
|
Ok |
|
You said OK, but merged without doing any changes. Do you plan to do it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.