Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpdstats: Don't record a skip when stopping MPD. #3725

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

aereaux
Copy link
Contributor

@aereaux aereaux commented Aug 10, 2020

Description

MPD keeps the current track in the queue when stopping, so it's not
really like a skip, and I use it so that I can stop the music, and later
start at the beginning of a track.

I do this by keeping track of the current song id, and then comparing
them when we receive a stop signal.

Fixes #3722 .

To Do

  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

@aereaux aereaux force-pushed the mpdstats_stop_no_skip branch from 39917c7 to 98946c1 Compare August 10, 2020 02:31
@sampsyo
Copy link
Member

sampsyo commented Aug 10, 2020

Seems pretty good to me! Would you mind adding a changelog entry describing the change?

MPD keeps the current track in the queue when stopping, so it's not
really like a skip, and I use it so that I can stop the music, and later
start at the beginning of a track.

I do this by keeping track of the current song id, and then comparing
them when we receive a stop signal.
@aereaux aereaux force-pushed the mpdstats_stop_no_skip branch from 98946c1 to fce27e6 Compare August 10, 2020 14:07
@aereaux
Copy link
Contributor Author

aereaux commented Aug 10, 2020

Added.

@sampsyo
Copy link
Member

sampsyo commented Aug 10, 2020

Excellent; thank you!

@sampsyo sampsyo merged commit eb6bbae into beetbox:master Aug 10, 2020
@aereaux aereaux deleted the mpdstats_stop_no_skip branch May 12, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mpdstats records a skip when stopping playback
2 participants