lastgenre plugin: genres canonicalization #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (because not in user whitelist), try to found a parent tag that is accepted
|
This has been merged (even if GitHub didn't automatically detect it). I changed the plugin to use the "canonical:" configuration value to set the path to the YAML dictionary. Canonicalization is also disabled by default. This is to prevent a dependency on pyyaml for people who don't need canonicalization. See the plugin docs (also written for the merge) for specifics. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add genres canonicalization: when a last.fm tag is found but rejected (because not in user whitelist), try to found a parent tag that is accepted.
I did use http://en.wikipedia.org/wiki/List_of_popular_music_genres as reference to build the tree and did read specific genres pages to better comprehend filiations between genres and move nodes in the base tree.