You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
beet web provides GET operations to fetch track items and albums. By default this removes paths
from the returned data, but the config setting INCLUDE_PATHS should allow the paths to be returned.
This works correctly for GET /item/... but not GET /album/... In the album case, the artpath is unconditionally deleted from the results.
Setup
Add to config file:
web:
include_paths: true
Use beet web to make a webserver available and do a GET /album/N, where N is the album id of an album in the database which has a cover art set. The JSON result should include the 'artpath' value but does not.
OS: Linux (Debian Testing)
Python version: 3.9.1-1
beets version: 1.4.9-7
Turning off plugins made problem go away (yes/no): bug in web plugin
Note this is a small issue, although I have hit it. I have a fix (and a regression test) which I will submit as a small PR once my first PR has been finished (so I can learn from the mistakes I made in that!).
The text was updated successfully, but these errors were encountered:
sampsyo
changed the title
Web api GET /album/<n> hides artpath even when INCLUDE_PATHS is set
web: GET /album/<n> hides artpath even when INCLUDE_PATHS is set
Mar 6, 2021
I see it as a bug, rather than a feature (as it works correctly for the item path) but I guess it doesn't really matter!
Anyway, I will submit the PR once the first one is completed. I forgot to create a separate branch for that one so I think it will be easier to manage once that is closed.
GrahamCobb
added a commit
to GrahamCobb/beets
that referenced
this issue
Mar 6, 2021
Problem
beet web
provides GET operations to fetch track items and albums. By default this removes pathsfrom the returned data, but the config setting INCLUDE_PATHS should allow the paths to be returned.
This works correctly for GET /item/... but not GET /album/... In the album case, the artpath is unconditionally deleted from the results.
Setup
Add to config file:
web:
include_paths: true
Use
beet web
to make a webserver available and do a GET /album/N, where N is the album id of an album in the database which has a cover art set. The JSON result should include the 'artpath' value but does not.Note this is a small issue, although I have hit it. I have a fix (and a regression test) which I will submit as a small PR once my first PR has been finished (so I can learn from the mistakes I made in that!).
The text was updated successfully, but these errors were encountered: