%ifdef does not work on flexattr fields with int or float

[wazabees]

Problem

If I try beet ls -a -f '$albumartist - (%if{$original_year,$original_year,$year}) - $album%ifdef{albumdisambig, (%title{$albumdisambig}),}%ifdef{albumrating, ($albumrating),}' year:2021 then beets will return the album rating for the albums that has the field defined. For albums without the rating, $albumrating is returned.

Example:

Artist1 - (2021) - Albumname1 (2.0)
Artist2 - (2021) - Albumname2 ($albumrating)

Further information on the forum:
https://discourse.beets.io/t/album-rating-as-a-flexible-attribute-in-5-increments/1687/3

Comment from adrian:
reading over the implementation of %ifdef, I can see now how it would be confused about types with a default value. That is, int or float fields will produce a '0' string for unset values through the formatter, which gets interpreted as non-missing. We clearly need better logic for this.

Setup

• OS: Arch Linux
• beets version 1.5.0
• Python version 3.9.1
• plugins: edit, extrafiles, fetchart, importadded, importfeeds, info, inline, lastimport, mbcollection, mbsync, mpdstats, mpdupdate, originquery, scrub, smartplaylist, types, zero

[sampsyo]

Thanks! The right fix here is to change the tmpl_ifdef method to look directly for the presence of a field rather than trying to go through the formatter.

[michaeltoohig]

I'm also facing this issue and glad to know it can be fixed. I thought it was my own user error though.

[spavitra1]

Hello, I would like to work on this bug.