-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
inline: Fix a ridiculously subtle flexattr bug
As detailed here: #2406 (comment) In a *function-style* definition, we didn't properly *un-define* the values for a given item after each function invocation. So when a field wasn't defined, it would get the value for the previously-formatted object instead. It now properly throws a NameError.
- Loading branch information
Showing
2 changed files
with
13 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81b1faa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super grateful to see this bug fixed! 🙏 It bit me when running
beet move
, causing inconsistent destinations depending on the item set.