-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI config #62
Update CI config #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Colored output is nice. I'm going to make a few more tweaks.
I pushed a indentation fix and The non-whitespace diff is clearer: https://github.com/bcomnes/npm-run-all2/pull/62/files?w=1 |
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
- Coverage 92.66% 92.56% -0.10%
==========================================
Files 23 22 -1
Lines 477 471 -6
==========================================
- Hits 442 436 -6
Misses 35 35
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* specify `FORCE_COLOR:2` so that we get colored output * specify `fail-fast: false` * switch to the actions tags when possible * reindent
Sorry to be so slow on these, in the middle of a move and just started a new job. |
No worries, take care! |
FORCE_COLOR:2
so that we get colored outputBTW it seems the actions don't fire on this repo from forks, so here is the run from my fork: https://github.com/XhmikosR/npm-run-all2/runs/3799626983
PS1. it seems tests break with Node.js 16 which is using npm 7.x. They changed how the
npm_config
stuff works. Personally I'm using aconfig
key in my package.json and that works on both npm 6 and 7.PS2. this will probably conflict with #61, ping me to rebase when needed
PS3. the engines package.json property is using
>=10
but Node.js 10 isn't tested on CI