-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use neostandard + add more static code analysis #142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Thanks for doing all of that. No breaking changes right? |
bcomnes
approved these changes
Jul 2, 2024
Only such change would be the narrowing of the engine definition to match that of the dependencies, else nothing 😌 |
@bcomnes You want me to merge or you will merge? :) |
I won't have time till later so feel free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
standard
withneostandard
and:npx eslint --fix
/* eslint-env mocha */
and replaces it withenv: ['mocha']
in theneostandard
config (it adds it globally, but I think that's okay for this project, a more deluxe solution would be to instead do: https://github.com/voxpelli/eslint-config/blob/main/base-configs/mocha.js)neostandard
badge, I opted for the one without the neostandard colors 😜Also:
rimraf
, because there's a dependency on it that worked whenstandard
made it be includedknip
to help avoid the aboveknip
installed-check
to ensure that the engine range is good