Add dynamic-stdc++ #400
Merged
Add dynamic-stdc++ #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
commented
Oct 11, 2024
|
i think i need diff flag here, in my testing it's still using the static version |
|
nvm, this does work as long as you have a valid libstdc++.so in the sysroot |
keith
force-pushed
the
ks/add-system-stdc-for-shared-libstdc-linking
branch
from
9bbf559 to
ab5f458
Compare
fmeum
approved these changes
Dec 20, 2024
fmeum
force-pushed
the
ks/add-system-stdc-for-shared-libstdc-linking
branch
from
e882bcb to
1bccf2d
Compare
keith
changed the title
keith
changed the title
|
ci fix: #427 |
Depending on your project statically linking libstdc++ from your sysroot might not be viable. For example if you rely on other shared libraries that link the shared version, linking the static version to a binary might result in ODR violations. This new `system-stdc++` sets the compile flags correctly but doesn't force the static version, so the sysroot's shared version will be preferred.
keith
force-pushed
the
ks/add-system-stdc-for-shared-libstdc-linking
branch
from
1bccf2d to
5ed9eda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on your project statically linking libstdc++ from your sysroot
might not be viable. For example if you rely on other shared libraries
that link the shared version, linking the static version to a binary
might result in ODR violations. This new
dynamic-stdc++sets thecompile flags correctly but doesn't force the static version, so the
sysroot's shared version will be preferred.