Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enforce consistent-type-imports eslint rule on modern packages #204

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 6, 2025

I would have liked to use the verbatimModuleSyntax tsconfig, but that's only available for ESM projects.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 6, 2025 19:36
@mrgrain mrgrain force-pushed the mrgrain/chore/verbatimModuleSyntax branch from e096e77 to 1a61577 Compare March 6, 2025 19:36
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.48%. Comparing base (e3b0856) to head (1a61577).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   84.93%   85.48%   +0.55%     
==========================================
  Files         207      207              
  Lines       35760    35761       +1     
  Branches     4613     4671      +58     
==========================================
+ Hits        30371    30570     +199     
+ Misses       5238     5036     -202     
- Partials      151      155       +4     
Flag Coverage Δ
suite.unit 85.48% <100.00%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 6, 2025
@mrgrain mrgrain closed this Mar 6, 2025
auto-merge was automatically disabled March 6, 2025 19:50

Pull request was closed

@mrgrain mrgrain reopened this Mar 6, 2025
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit 47a4e1d Mar 6, 2025
23 of 24 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/chore/verbatimModuleSyntax branch March 6, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 pr/exempt-integ-test Skips the integ test steps if set.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants