feat(cli): build your own fromLookup() imports with the new context provider for CloudControl API
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A generic Context Provider for CloudControl API. Extracted from aws/aws-cdk#33258.
rix0rrr
requested a deployment
to
integ-approval
GitHub Actions
Waiting
rix0rrr
requested a deployment
to
integ-approval
GitHub Actions
Waiting
rix0rrr
requested a deployment
to
integ-approval
GitHub Actions
Waiting
rix0rrr
requested a deployment
to
integ-approval
GitHub Actions
Waiting
Signed-off-by: github-actions <[email protected]>
aws-cdk-automation
requested a deployment
to
integ-approval
GitHub Actions
Waiting
Signed-off-by: github-actions <[email protected]>
aws-cdk-automation
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
mrgrain
reviewed
Feb 25, 2025
mrgrain
reviewed
Feb 25, 2025
| @@ -31,6 +31,8 @@ import { | |||
| } from '../../lib/commands/migrate'; | |||
| import { MockSdkProvider, mockCloudFormationClient, restoreSdkMocksToDefault } from '../util/mock-sdk'; | |||
|
|
|||
| jest.setTimeout(120_000); | |||
mrgrain
requested changes
Feb 25, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
- Coverage 84.76% 84.58% -0.19%
==========================================
Files 196 198 +2
Lines 35187 35380 +193
Branches 4552 4555 +3
==========================================
+ Hits 29828 29926 +98
- Misses 5208 5310 +102
+ Partials 151 144 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: github-actions <[email protected]>
aws-cdk-automation
requested a deployment
to
integ-approval
GitHub Actions
Waiting
Signed-off-by: github-actions <[email protected]>
aws-cdk-automation
requested a deployment
to
integ-approval
GitHub Actions
Waiting
Signed-off-by: github-actions <[email protected]>
aws-cdk-automation
requested a deployment
to
integ-approval
GitHub Actions
Waiting
Signed-off-by: github-actions <[email protected]>
aws-cdk-automation
requested a deployment
to
integ-approval
GitHub Actions
Waiting
mrgrain
requested a deployment
to
integ-approval
GitHub Actions
Waiting
mrgrain
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
mrgrain
approved these changes
Feb 26, 2025
mrgrain
changed the title
mrgrain
changed the title
fromLookup() imports with the new context provider for CloudControl API
This was referenced Feb 27, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A generic Context Provider for CloudControl API. See aws/aws-cdk#33258 for an example how to implement a
fromLookup()method using the new context provider.(Extracted from aws/aws-cdk#33258)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license