Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADM-408 add unit test for buildkiteservice #253

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

bhan-tw
Copy link

@bhan-tw bhan-tw commented Mar 21, 2023

Summary

add unit test for buildkiteservice

@codacy-production
Copy link

codacy-production bot commented Mar 21, 2023

Coverage summary from Codacy

Merging #253 (ad31b0d) into main (527a121) - See PR on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (527a121) 1020 1020 100.00%
Head commit (ad31b0d) 1020 (+0) 1020 (+0) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#253) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@bhan-tw bhan-tw force-pushed the ADM-408-add-test-for-buildkite-service branch from 55c8da3 to ad31b0d Compare March 21, 2023 05:27

@Test
void shouldThrowRequestFailedExceptionWhenFeignClientCallFailed() {
// Mock Feign Client
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use blank line to distinguish given when then,maybe remove it next time

@bhan-tw bhan-tw merged commit c0181a4 into main Mar 21, 2023
@bhan-tw bhan-tw deleted the ADM-408-add-test-for-buildkite-service branch March 21, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants