Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix used-dummy-variable ruff warnings #3083

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix used-dummy-variable ruff warnings #3083

merged 1 commit into from
Jan 7, 2025

Conversation

correctmost
Copy link
Contributor

PR Description:

This PR fixes some warnings that show up when running ruff check --preview locally:

archinstall/lib/installer.py:150:4: RUF052 Local dummy variable `_started_wait` is accessed
archinstall/lib/installer.py:151:4: RUF052 Local dummy variable `_notified` is accessed
archinstall/lib/installer.py:154:6: RUF052 Local dummy variable `_notified` is accessed
archinstall/lib/models/mirrors.py:51:4: RUF052 Local dummy variable `_retry` is accessed
archinstall/lib/models/mirrors.py:74:5: RUF052 Local dummy variable `_retry` is accessed
archinstall/lib/models/mirrors.py:106:20: RUF052 Local dummy variable `_port` is accessed

Docs:

@correctmost correctmost requested a review from Torxed as a code owner January 5, 2025 06:24
@svartkanin svartkanin merged commit 40210f8 into archlinux:master Jan 7, 2025
8 checks passed
@correctmost correctmost deleted the cm/fix-dummy-var-warnings branch January 7, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svartkanin svartkanin svartkanin approved these changes

@Torxed Torxed Awaiting requested review from Torxed Torxed is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@correctmost @svartkanin