Enable the "unreachable" pylint warning and remove unused code #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The os.fsync call causes an "invalid argument" OSError when it actually runs, so it has been removed altogether. Closes archlinux#2773
svartkanin
approved these changes
Dec 1, 2024
castillofrancodamian
pushed a commit
to castillofrancodamian/archinstall
that referenced
this pull request
Dec 21, 2024
…inux#2987) The os.fsync call causes an "invalid argument" OSError when it actually runs, so it has been removed altogether. Closes archlinux#2773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
The
os.fsynccall causes an "invalid argument" OSError when it actually runs, so it has been removed altogether.Closes #2773
Tests and Checks