THRIFT-1482: Unix domain socket support under PHP #3109
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client: php To open a unix socket, the port number supplied to fsockopen (and pfsockopen) has to be -1. We use substr instead of str_starts_with to keep compatibility with php 7.
sveneld
suggested changes
Mar 10, 2025
| @@ -218,7 +218,7 @@ public function open() | |||
| throw new TTransportException('Cannot open null host', TTransportException::NOT_OPEN); | |||
| } | |||
|
|
|||
| if ($this->port_ <= 0) { | |||
| if ($this->port_ <= 0 && substr($this->host_, 0, strlen('unix://')) !== 'unix://') { | |||
There was a problem hiding this comment.
you can make this check like this
if ($this->port_ <= 0 && strpos($this->host_, 'unix://') !== 0) {
update a unit test lib/php/test/Unit/Lib/Transport/TSocketTest.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To open a unix socket, the port number supplied to
fsockopen(andpfsockopen) has to be-1.We use
substrinstead ofstr_starts_withto keep compatibility with php 7.Now a UDS can be created like this:
[skip ci]anywhere in the commit message to free up build resources.