[build] Support e2e tests on jdk11 #5245
Merged
+25
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyubin117
force-pushed
the
e2e-tests-jdk11
branch
from
096d572 to
7b952b1
Compare
|
@JingsongLi CI passed, PTAL, thanks :) |
liyubin117
force-pushed
the
e2e-tests-jdk11
branch
from
7b952b1 to
6ac3b61
Compare
JingsongLi
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
After the Maven compilation on JDK11, the generated jar is also built with JDK11, accordingly, the JDK in the E2E container should also be JDK11, otherwise it will remain abnormal as it was. so we should:
apache/flink:${test.flink.version}-${test.java.version}instead ofapache/flink:${test.flink.version}-java8,SparkE2eTestandHiveE2eTestas @DisabledOnJre(JAVA_11) because not support their jdk11 container and should not block the other 21 tests.e2e-tests on jdk8: https://github.com/liyubin117/paimon/actions/runs/13760620698/job/38475787890
e2e-tests on jdk11: https://github.com/liyubin117/paimon/actions/runs/13760620697/job/38475787701
Tests
API and Format
Documentation