fix: use UTF-8 as a default encoding in HTTP sampler #6010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
force-pushed
the
filename_encoding
branch
7 times, most recently
from
3b110ed to
5bfceca
Compare
vlsi
commented
Jun 29, 2023
Comment on lines
+132
to
+133
| default: | ||
| sb.append(c); |
There was a problem hiding this comment.
In theory, % should be escaped as well so the server-side can tell the difference between ".txt and %22.txt, however, current Chrome does not escape %, so when they change we change
In PR 5987 HTTP sampler encoded filenames with percent encoding, however, it should not encode all the characters. Fixes apache#6005 This is a fixup to apache#5987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR 5987 HTTP sampler encoded filenames with percent encoding, however, it should not encode all the characters.
Fixes #6005
This is a fixup to #5987
Motivation and Context
HTTP sampler should send requests like browsers do: UTF-8 encoded filenames.