Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cant encode pointer of raw type #282 #283

Merged
merged 13 commits into from
Oct 13, 2021

Conversation

ChangedenCZD
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #282

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@ChangedenCZD
Copy link
Contributor Author

暂时有bug,待修复

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #283 (43d1925) into master (a0c5132) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   70.21%   70.27%   +0.05%     
==========================================
  Files          27       27              
  Lines        3028     3034       +6     
==========================================
+ Hits         2126     2132       +6     
  Misses        677      677              
  Partials      225      225              
Impacted Files Coverage Δ
encode.go 77.67% <100.00%> (+0.82%) ⬆️
pojo.go 63.94% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c5132...43d1925. Read the comment docs.

@wongoo wongoo changed the title fixed: #282 fix issue #282 Oct 12, 2021
Copy link
Contributor

@wongoo wongoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wongoo wongoo requested review from fangyincheng and zouyx October 13, 2021 03:43
@zouyx zouyx merged commit ea64fc7 into apache:master Oct 13, 2021
@wongoo wongoo changed the title fix issue #282 fix cant encode pointer of raw type #282 Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

encode *string type error
5 participants