Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hessian codec bugs #167

Merged
merged 10 commits into from
Mar 18, 2020
Merged

Fix hessian codec bugs #167

merged 10 commits into from
Mar 18, 2020

Conversation

zonghaishang
Copy link
Member

@zonghaishang zonghaishang commented Mar 17, 2020

What this PR does:

Which issue(s) this PR fixes:

Fixes #164
Fixes #168

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@zonghaishang
Copy link
Member Author

@wongoo Please help check TestList test case, local run is passed

https://travis-ci.org/github/apache/dubbo-go-hessian2/builds/663769046?utm_source=github_status&utm_medium=notification

error stack:

=== RUN   TestList
--- FAIL: TestList (0.00s)
panic: assignment to entry in nil map [recovered]
	panic: assignment to entry in nil map
goroutine 484 [running]:
testing.tRunner.func1(0xc00039c500)
	/home/travis/.gimme/versions/go1.11.1.linux.amd64/src/testing/testing.go:792 +0x6a7
panic(0x88d280, 0x95fe00)
	/home/travis/.gimme/versions/go1.11.1.linux.amd64/src/runtime/panic.go:513 +0x1b9
github.com/apache/dubbo-go-hessian2.RegisterPOJO(0x960880, 0xc10c20, 0x0)
	/home/travis/build/apache/dubbo-go-hessian2/pojo.go:149 +0x2f9
github.com/apache/dubbo-go-hessian2.RegisterPOJOs(0xc0001b9f38, 0x3, 0x3, 0xc0000a4cc0, 0x871c00, 0x95e650)
	/home/travis/build/apache/dubbo-go-hessian2/pojo.go:218 +0xf6
github.com/apache/dubbo-go-hessian2.TestList(0xc00039c500)
	/home/travis/build/apache/dubbo-go-hessian2/list_test.go:75 +0x125
testing.tRunner(0xc00039c500, 0x906fc8)
	/home/travis/.gimme/versions/go1.11.1.linux.amd64/src/testing/testing.go:827 +0x163
created by testing.(*T).Run
	/home/travis/.gimme/versions/go1.11.1.linux.amd64/src/testing/testing.go:878 +0x651
exit status 2
FAIL	github.com/apache/dubbo-go-hessian2	30.313s

@codecov-io
Copy link

codecov-io commented Mar 18, 2020

Codecov Report

Merging #167 into master will increase coverage by 0.96%.
The diff coverage is 87.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   66.45%   67.42%   +0.96%     
==========================================
  Files          21       22       +1     
  Lines        2573     2671      +98     
==========================================
+ Hits         1710     1801      +91     
+ Misses        667      666       -1     
- Partials      196      204       +8
Impacted Files Coverage Δ
response.go 56.37% <100%> (+7.11%) ⬆️
object.go 64.61% <66.66%> (+1%) ⬆️
pojo.go 60.1% <91.66%> (+3.56%) ⬆️
java_collection.go 54.66% <0%> (ø)
list.go 85.38% <0%> (+0.27%) ⬆️
codec.go 65.83% <0%> (+0.83%) ⬆️
hessian.go 48.14% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1d1660...5b10665. Read the comment docs.

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wongoo
Copy link
Contributor

wongoo commented Mar 18, 2020

LGTM

@wongoo wongoo merged commit 0da2291 into apache:master Mar 18, 2020
zhaoyunxing92 pushed a commit that referenced this pull request Sep 4, 2021
* fix skip class fields.

* fix skip class fields & decode response attachments.

* remove unit tests.

* fix code review problems.

* Fix when the return value is nil

* refactor code.

* add UnRegisterPOJO for tests.

* refactor codes.

* remove construct structInfo.

* cancel export unRegisterPOJOs method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

修复hessian解码dubbo response attachment问题 支持解码dubbo请求方法复杂类型,晚点提pr
4 participants