-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flat anonymous struct field #154
Conversation
need merge #150 first |
I will review this PR after #150 being merged. |
Pls resolve conflicts @micln |
should we support embed pointer like type Dog struct{
*Aninal
} The super class in java will not be null, so the protocal don't need handle it. That means we can't marshal the ptr to a nil (and new a instance to hold feilds). So I think we don't need to support the embed pointer today. |
@fangyincheng @wanghbxxxx @aliiohs pls review this agian, thanks |
agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@micln pls update the readme. add some explanation about java&go inheritance, and the anonymous struct field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@micln pls push a new PR if need update readme or demo |
* fix issue 149 - embed struct * remove serialUID * mapping extends to all feilds * flat * readme * update readme
What this PR does:
hessian:"-"
#153
Special notes for your reviewer:
when find a anonymous field in scanning struct's fields, encoding/json will flat field immediately. but I put the field to queue and flat latter
Does this PR introduce a user-facing change?: