Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3440] Implement the refresh and exploration of OptimizingGroup… #3457

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mansonliwh
Copy link
Contributor

@mansonliwh mansonliwh commented Mar 5, 2025

Why are the changes needed?

Close #3440 .

Brief change log

The OptimizingService and OptimizerManager have been decoupled: the OptimizerManager handles metadata persistence and modifications, while the OptimizingService includes a watcher to synchronize the in-memory OptimizingQueue map with persisted data.
This allows the master node to run the OptimizingService while other nodes modify metadata via a web interface, ensuring the master stays updated.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 52.08333% with 46 lines in your changes missing coverage. Please review.

Project coverage is 27.87%. Comparing base (63aab48) to head (bcbf88f).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...amoro/server/resource/DefaultOptimizerManager.java 11.11% 24 Missing ⚠️
.../java/org/apache/amoro/resource/ResourceGroup.java 0.00% 9 Missing ⚠️
.../apache/amoro/server/DefaultOptimizingService.java 85.10% 7 Missing ⚠️
...dashboard/controller/OptimizerGroupController.java 0.00% 5 Missing ⚠️
...rver/dashboard/controller/OptimizerController.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3457      +/-   ##
============================================
+ Coverage     21.59%   27.87%   +6.28%     
- Complexity     2353     3641    +1288     
============================================
  Files           431      603     +172     
  Lines         40347    49270    +8923     
  Branches       5711     6348     +637     
============================================
+ Hits           8712    13734    +5022     
- Misses        30903    34581    +3678     
- Partials        732      955     +223     
Flag Coverage Δ
core 27.87% <52.08%> (?)
trino ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mansonliwh mansonliwh force-pushed the optimizing-config branch 2 times, most recently from 5dcc38c to 54ff948 Compare March 6, 2025 03:36
@mansonliwh mansonliwh changed the title draft:[AMORO-3440] Implement the refresh and exploration of OptimizingGroup… [AMORO-3440] Implement the refresh and exploration of OptimizingGroup… Mar 6, 2025
@czy006 czy006 requested review from baiyangtx and zhoujinsong March 10, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask]: Implement the refresh and exploration of OptimizingGroupConfig
2 participants