fix: make indirect host counting live test more reliable #15870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I had also started in this direction, but I think it misses something. The loop this is adding doesn't make any sense, because it duplicates an existing loop and is using the wrong heuristic. I think this was already "fixed", but that fix didn't anticipate that the task didn't need to be restarted, yet at the same time, was still running and could be out-paced by the test. Can't say it in words well enough, put up - #15871 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Make the live tests for indirect host counting more reliable. Wait until all events have been processed, before running
save_indirect_host_entriesand then checking audit records.ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION