tests: Test on all os platforms #32
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,15 +10,24 @@ on: | |
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest, windows-latest] | ||
| emacs-version: | ||
| - 26.3 | ||
| - 27.2 | ||
| - 28.2 | ||
| - snapshot | ||
|
There was a problem hiding this comment. This is good. Agreed, this is a good call. |
||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Setup Emacs | ||
| uses: jcs090218/setup-emacs@master | ||
|
There was a problem hiding this comment. Is there a reason you changed the setup action. I appreciate the fact you're building your own custom action, but purcell/setup-emacs seems in wider use ( currently ). Happy to change if it there's a good reason. There was a problem hiding this comment. purcell's action don't support windows, and I don't think it will ever going to support it. |
||
| with: | ||
| version: ${{ matrix.emacs-version }} | ||
|
|
||
| - name: Emacs Lisp check | ||
| uses: leotaku/[email protected] | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to check out if free tier on github can run macos and windows jobs. Can you confirm they can?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they can! I have been using it since 2019? 2020? (Sorry, don't remember the exact year) Example repo, see https://github.com/emacs-sideline/sideline.