content modelling/949 change name to title #9997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harriethw
force-pushed
the
content-modelling/949-change-name-to-title
branch
4 times, most recently
from
099dcab to
7211bfd
Compare
Harriethw
force-pushed
the
content-modelling/949-change-name-to-title
branch
from
7211bfd to
c2e21b5
Compare
pezholio
approved these changes
Mar 3, 2025
This follows changes to the embedded object schema in Publishing API. [1] It's a bit complicated because we have been using the `name` everywhere as the key/slug for a rate within the JSON `details` of a block - so a fair bit of code touched to update that. [1] alphagov/publishing-api#3165
this changes the column name on `versions` to reflect that the new key is `title` on embedded objects.
Harriethw
force-pushed
the
content-modelling/949-change-name-to-title
branch
from
c2e21b5 to
2e25e55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/bMiirLNG/949-rate-object-attribute-should-be-title
Can be merged once Publishing API changes made: alphagov/publishing-api#3165
Wherever we have the
namekey on an embedded object it should now betitle- including where the key for the object is generated, and on versions.nametotitleupdated_embedded_object_nametoupdated_embedded_object_titleFollow these steps if you are doing a Rails upgrade.