-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
binding config schema validation for unused properties #929
Conversation
"additionalProperties": false | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that server
options are a superset of client
options, is there not a way to specify the common subset once, and then conditionally include the additional options properties for server
?
Note: Prior to this change, binding-grpc binding-kafka binding-mqtt binding-tls binding-ws binding-http |
net0: | ||
type: test | ||
kind: server | ||
entry: entry0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any reference to entry0
is this expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this script is added to test negative scenario(if kind: server, entry property is not allowed). expected output is JsonException
. So I thought having an entry defined might not be required.
Fixes #808