Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use per worker registration for composite namespaces #910

Merged
merged 2 commits into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ public final class AsyncapiBindingConfig
private final Map<CharSequence, String> operationIds;
private final LongFunction<CatalogHandler> supplyCatalog;
private final ToLongFunction<String> resolveId;
private final Consumer<NamespaceConfig> attach;
private final Consumer<NamespaceConfig> detach;
private final long overrideRouteId;
private final HttpHeaderHelper helper;
Expand All @@ -80,6 +81,8 @@ public AsyncapiBindingConfig(
BindingConfig binding,
AsyncapiNamespaceGenerator namespaceGenerator,
LongFunction<CatalogHandler> supplyCatalog,
Consumer<NamespaceConfig> attachComposite,
Consumer<NamespaceConfig> detachComposite,
long overrideRouteId)
{
this.id = binding.id;
Expand All @@ -99,7 +102,8 @@ public AsyncapiBindingConfig(
this.operationIds = new TreeMap<>(CharSequence::compare);
this.helper = new HttpHeaderHelper();
this.parser = new AsyncapiParser();
this.detach = binding.detach;
this.attach = attachComposite;
this.detach = detachComposite;
this.routes = binding.routes.stream().map(r -> new AsyncapiRouteConfig(r, schemaIdsByApiId::get)).collect(toList());
}

Expand Down Expand Up @@ -218,9 +222,9 @@ private void attachProxyBinding(
(existingValue, newValue) -> existingValue,
Object2ObjectHashMap::new));

final NamespaceConfig composite = binding.attach.apply(namespaceGenerator.generateProxy(binding, asyncapis,
schemaIdsByApiId::get));

final NamespaceConfig composite = namespaceGenerator.generateProxy(binding, asyncapis, schemaIdsByApiId::get);
composite.readURL = binding.readURL;
attach.accept(composite);
for (AsyncapiSchemaConfig config : configs)
{
Asyncapi asyncapi = config.asyncapi;
Expand All @@ -235,7 +239,9 @@ private void attachServerClientBinding(
for (AsyncapiSchemaConfig config : configs)
{
Asyncapi asyncapi = config.asyncapi;
final NamespaceConfig composite = binding.attach.apply(namespaceGenerator.generate(binding, asyncapi));
final NamespaceConfig composite = namespaceGenerator.generate(binding, asyncapi);
composite.readURL = binding.readURL;
attach.accept(composite);
updateNamespace(config, composite, asyncapi);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
*/
package io.aklivity.zilla.runtime.binding.asyncapi.internal.stream;

import java.util.function.Consumer;
import java.util.function.LongFunction;
import java.util.function.LongSupplier;
import java.util.function.LongUnaryOperator;
Expand Down Expand Up @@ -43,6 +44,7 @@
import io.aklivity.zilla.runtime.engine.buffer.BufferPool;
import io.aklivity.zilla.runtime.engine.catalog.CatalogHandler;
import io.aklivity.zilla.runtime.engine.config.BindingConfig;
import io.aklivity.zilla.runtime.engine.config.NamespaceConfig;

public final class AsyncapiClientFactory implements AsyncapiStreamFactory
{
Expand Down Expand Up @@ -77,6 +79,8 @@ public final class AsyncapiClientFactory implements AsyncapiStreamFactory
private final LongUnaryOperator supplyReplyId;
private final LongSupplier supplyTraceId;
private final LongFunction<CatalogHandler> supplyCatalog;
private final Consumer<NamespaceConfig> attachComposite;
private final Consumer<NamespaceConfig> detachComposite;
private final Long2ObjectHashMap<AsyncapiBindingConfig> bindings;
private final int asyncapiTypeId;
private final int mqttTypeId;
Expand All @@ -98,6 +102,8 @@ public AsyncapiClientFactory(
this.supplyReplyId = context::supplyReplyId;
this.supplyTraceId = context::supplyTraceId;
this.supplyCatalog = context::supplyCatalog;
this.attachComposite = context::attachComposite;
this.detachComposite = context::detachComposite;
this.bindings = new Long2ObjectHashMap<>();
this.asyncapiTypeId = context.supplyTypeId(AsyncapiBinding.NAME);
this.mqttTypeId = context.supplyTypeId(MQTT_TYPE_NAME);
Expand All @@ -120,7 +126,7 @@ public void attach(
BindingConfig binding)
{
AsyncapiBindingConfig asyncapiBinding = new AsyncapiBindingConfig(binding, namespaceGenerator, supplyCatalog,
config.targetRouteId());
attachComposite, detachComposite, config.targetRouteId());
bindings.put(binding.id, asyncapiBinding);

asyncapiBinding.attach(binding);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
package io.aklivity.zilla.runtime.binding.asyncapi.internal.stream;

import java.util.Optional;
import java.util.function.Consumer;
import java.util.function.Function;
import java.util.function.LongFunction;
import java.util.function.LongSupplier;
Expand Down Expand Up @@ -47,6 +48,7 @@
import io.aklivity.zilla.runtime.engine.buffer.BufferPool;
import io.aklivity.zilla.runtime.engine.catalog.CatalogHandler;
import io.aklivity.zilla.runtime.engine.config.BindingConfig;
import io.aklivity.zilla.runtime.engine.config.NamespaceConfig;

public final class AsyncapiProxyFactory implements AsyncapiStreamFactory
{
Expand Down Expand Up @@ -80,6 +82,8 @@ public final class AsyncapiProxyFactory implements AsyncapiStreamFactory
private final LongSupplier supplyTraceId;
private final Function<String, Integer> supplyTypeId;
private final LongFunction<CatalogHandler> supplyCatalog;
private final Consumer<NamespaceConfig> attachComposite;
private final Consumer<NamespaceConfig> detachComposite;
private final Long2ObjectHashMap<AsyncapiBindingConfig> bindings;
private final Long2LongHashMap apiIds;
private final AsyncapiConfiguration config;
Expand All @@ -102,6 +106,8 @@ public AsyncapiProxyFactory(
this.supplyTypeId = context::supplyTypeId;
this.supplyTraceId = context::supplyTraceId;
this.supplyCatalog = context::supplyCatalog;
this.attachComposite = context::attachComposite;
this.detachComposite = context::detachComposite;
this.bindings = new Long2ObjectHashMap<>();
this.apiIds = new Long2LongHashMap(-1);
this.asyncapiTypeId = context.supplyTypeId(AsyncapiBinding.NAME);
Expand All @@ -119,7 +125,7 @@ public void attach(
BindingConfig binding)
{
AsyncapiBindingConfig asyncapiBinding = new AsyncapiBindingConfig(binding, namespaceGenerator,
supplyCatalog, config.targetRouteId());
supplyCatalog, attachComposite, detachComposite, config.targetRouteId());
bindings.put(binding.id, asyncapiBinding);

asyncapiBinding.attach(binding);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
*/
package io.aklivity.zilla.runtime.binding.asyncapi.internal.stream;

import java.util.function.Consumer;
import java.util.function.Function;
import java.util.function.LongFunction;
import java.util.function.LongSupplier;
Expand Down Expand Up @@ -47,6 +48,7 @@
import io.aklivity.zilla.runtime.engine.buffer.BufferPool;
import io.aklivity.zilla.runtime.engine.catalog.CatalogHandler;
import io.aklivity.zilla.runtime.engine.config.BindingConfig;
import io.aklivity.zilla.runtime.engine.config.NamespaceConfig;

public final class AsyncapiServerFactory implements AsyncapiStreamFactory
{
Expand Down Expand Up @@ -86,6 +88,8 @@ public final class AsyncapiServerFactory implements AsyncapiStreamFactory
private final LongSupplier supplyTraceId;
private final Function<String, Integer> supplyTypeId;
private final LongFunction<CatalogHandler> supplyCatalog;
private final Consumer<NamespaceConfig> attachComposite;
private final Consumer<NamespaceConfig> detachComposite;
private final Long2ObjectHashMap<AsyncapiBindingConfig> bindings;
private final int asyncapiTypeId;
private final int mqttTypeId;
Expand All @@ -108,6 +112,8 @@ public AsyncapiServerFactory(
this.supplyTypeId = context::supplyTypeId;
this.supplyTraceId = context::supplyTraceId;
this.supplyCatalog = context::supplyCatalog;
this.attachComposite = context::attachComposite;
this.detachComposite = context::detachComposite;
this.bindings = new Long2ObjectHashMap<>();
this.asyncapiTypeId = context.supplyTypeId(AsyncapiBinding.NAME);
this.mqttTypeId = context.supplyTypeId(MQTT_TYPE_NAME);
Expand All @@ -131,7 +137,7 @@ public void attach(
BindingConfig binding)
{
AsyncapiBindingConfig asyncapiBinding = new AsyncapiBindingConfig(binding, namespaceGenerator, supplyCatalog,
config.targetRouteId());
attachComposite, detachComposite, config.targetRouteId());
bindings.put(binding.id, asyncapiBinding);

asyncapiBinding.attach(binding);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ public final class OpenapiAsyncapiBindingConfig
private final Object2LongHashMap<String> asyncapiSchemaIdsByApiId;
private final AsyncapiParser asyncapiParser;
private final OpenapiParser openapiParser;
private final Consumer<NamespaceConfig> attach;
private final Consumer<NamespaceConfig> detach;

private NamespaceConfig composite;
Expand All @@ -70,14 +71,17 @@ public final class OpenapiAsyncapiBindingConfig
public OpenapiAsyncapiBindingConfig(
BindingConfig binding,
OpenapiAsyncNamespaceGenerator namespaceGenerator,
LongFunction<CatalogHandler> supplyCatalog)
LongFunction<CatalogHandler> supplyCatalog,
Consumer<NamespaceConfig> attachComposite,
Consumer<NamespaceConfig> detachComposite)
{
this.id = binding.id;
this.name = binding.name;
this.kind = binding.kind;
this.options = (OpenapiAsyncapiOptionsConfig) binding.options;
this.resolvedIds = binding.resolveId;
this.detach = binding.detach;
this.attach = attachComposite;
this.detach = detachComposite;
this.openapiSchemaIdsByApiId = new Object2LongHashMap<>(-1);
this.asyncapiSchemaIdsByApiId = new Object2LongHashMap<>(-1);
this.compositeResolvedIds = new Long2LongHashMap(-1);
Expand Down Expand Up @@ -139,8 +143,9 @@ public void attach(
(e, n) -> e,
Object2ObjectHashMap::new));

this.composite = binding.attach.apply(namespaceGenerator.generate(binding, openapis,
asyncapis, openapiSchemaIdsByApiId::get));
this.composite = namespaceGenerator.generate(binding, openapis, asyncapis, openapiSchemaIdsByApiId::get);
this.composite.readURL = binding.readURL;
attach.accept(this.composite);

BindingConfig mappingBinding = composite.bindings.stream()
.filter(b -> b.type.equals("http-kafka")).findFirst().get();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
*/
package io.aklivity.zilla.runtime.binding.openapi.asyncapi.internal.streams;

import java.util.function.Consumer;
import java.util.function.LongFunction;
import java.util.function.LongSupplier;
import java.util.function.LongUnaryOperator;
Expand Down Expand Up @@ -47,6 +48,7 @@
import io.aklivity.zilla.runtime.engine.buffer.BufferPool;
import io.aklivity.zilla.runtime.engine.catalog.CatalogHandler;
import io.aklivity.zilla.runtime.engine.config.BindingConfig;
import io.aklivity.zilla.runtime.engine.config.NamespaceConfig;

public final class OpenapiAsyncapiProxyFactory implements OpenapiAsyncapiStreamFactory
{
Expand Down Expand Up @@ -83,6 +85,8 @@ public final class OpenapiAsyncapiProxyFactory implements OpenapiAsyncapiStreamF
private final LongUnaryOperator supplyReplyId;
private final LongSupplier supplyTraceId;
private final LongFunction<CatalogHandler> supplyCatalog;
private final Consumer<NamespaceConfig> attachComposite;
private final Consumer<NamespaceConfig> detachComposite;
private final Long2ObjectHashMap<OpenapiAsyncapiBindingConfig> bindings;
private final Long2LongHashMap apiIds;
private final OpenapiAsyncapiConfiguration config;
Expand All @@ -104,6 +108,8 @@ public OpenapiAsyncapiProxyFactory(
this.supplyReplyId = context::supplyReplyId;
this.supplyTraceId = context::supplyTraceId;
this.supplyCatalog = context::supplyCatalog;
this.attachComposite = context::attachComposite;
this.detachComposite = context::detachComposite;
this.bindings = new Long2ObjectHashMap<>();
this.apiIds = new Long2LongHashMap(-1);
this.openapiTypeId = context.supplyTypeId(OpenapiBinding.NAME);
Expand All @@ -122,7 +128,7 @@ public void attach(
BindingConfig binding)
{
OpenapiAsyncapiBindingConfig apiBinding = new OpenapiAsyncapiBindingConfig(binding,
namespaceGenerator, supplyCatalog);
namespaceGenerator, supplyCatalog, attachComposite, detachComposite);
bindings.put(binding.id, apiBinding);

apiBinding.attach(binding);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ public final class OpenapiBindingConfig
private final Long2LongHashMap apiIdsByNamespaceId;
private final HttpHeaderHelper helper;
private final OpenapiParser parser;
private final Consumer<NamespaceConfig> attach;
private final Consumer<NamespaceConfig> detach;
private final Long2LongHashMap resolvedIds;
private final Object2ObjectHashMap<Matcher, OpenapiPathItem> paths;
Expand All @@ -79,6 +80,8 @@ public OpenapiBindingConfig(
BindingConfig binding,
OpenapiNamespaceGenerator namespaceGenerator,
LongFunction<CatalogHandler> supplyCatalog,
Consumer<NamespaceConfig> attachComposite,
Consumer<NamespaceConfig> detachComposite,
long overrideRouteId)
{
this.id = binding.id;
Expand All @@ -96,7 +99,8 @@ public OpenapiBindingConfig(
this.httpOrigins = new IntHashSet(-1);
this.parser = new OpenapiParser();
this.helper = new HttpHeaderHelper();
this.detach = binding.detach;
this.attach = attachComposite;
this.detach = detachComposite;
this.routes = binding.routes.stream().map(OpenapiRouteConfig::new).collect(toList());

Map<CharSequence, Function<OpenapiPathItem, String>> resolversByMethod = new TreeMap<>(CharSequence::compare);
Expand All @@ -118,7 +122,9 @@ public void attach(
configs.forEach(c ->
{
Openapi openapi = c.openapi;
final NamespaceConfig composite = binding.attach.apply(namespaceGenerator.generate(binding, openapi));
final NamespaceConfig composite = namespaceGenerator.generate(binding, openapi);
composite.readURL = binding.readURL;
attach.accept(composite);
composites.put(c.schemaId, composite);
openapi.paths.forEach((k, v) ->
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
*/
package io.aklivity.zilla.runtime.binding.openapi.internal.streams;

import java.util.function.Consumer;
import java.util.function.LongFunction;
import java.util.function.LongSupplier;
import java.util.function.LongUnaryOperator;
Expand Down Expand Up @@ -43,6 +44,7 @@
import io.aklivity.zilla.runtime.engine.buffer.BufferPool;
import io.aklivity.zilla.runtime.engine.catalog.CatalogHandler;
import io.aklivity.zilla.runtime.engine.config.BindingConfig;
import io.aklivity.zilla.runtime.engine.config.NamespaceConfig;

public final class OpenapiClientFactory implements OpenapiStreamFactory
{
Expand Down Expand Up @@ -79,11 +81,12 @@ public final class OpenapiClientFactory implements OpenapiStreamFactory
private final LongUnaryOperator supplyReplyId;
private final LongSupplier supplyTraceId;
private final LongFunction<CatalogHandler> supplyCatalog;
private final Consumer<NamespaceConfig> attachComposite;
private final Consumer<NamespaceConfig> detachComposite;
private final Long2ObjectHashMap<OpenapiBindingConfig> bindings;
private final int openapiTypeId;
private final int httpTypeId;


public OpenapiClientFactory(
OpenapiConfiguration config,
EngineContext context)
Expand All @@ -97,6 +100,8 @@ public OpenapiClientFactory(
this.supplyReplyId = context::supplyReplyId;
this.supplyTraceId = context::supplyTraceId;
this.supplyCatalog = context::supplyCatalog;
this.attachComposite = context::attachComposite;
this.detachComposite = context::detachComposite;
this.namespaceGenerator = new OpenapiClientNamespaceGenerator();
this.bindings = new Long2ObjectHashMap<>();
this.openapiTypeId = context.supplyTypeId(OpenapiBinding.NAME);
Expand All @@ -120,7 +125,7 @@ public void attach(
BindingConfig binding)
{
OpenapiBindingConfig openapiBinding = new OpenapiBindingConfig(binding, namespaceGenerator, supplyCatalog,
config.targetRouteId());
attachComposite, detachComposite, config.targetRouteId());
bindings.put(binding.id, openapiBinding);

openapiBinding.attach(binding);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
*/
package io.aklivity.zilla.runtime.binding.openapi.internal.streams;

import java.util.function.Consumer;
import java.util.function.LongFunction;
import java.util.function.LongSupplier;
import java.util.function.LongUnaryOperator;
Expand Down Expand Up @@ -45,6 +46,7 @@
import io.aklivity.zilla.runtime.engine.buffer.BufferPool;
import io.aklivity.zilla.runtime.engine.catalog.CatalogHandler;
import io.aklivity.zilla.runtime.engine.config.BindingConfig;
import io.aklivity.zilla.runtime.engine.config.NamespaceConfig;

public final class OpenapiServerFactory implements OpenapiStreamFactory
{
Expand Down Expand Up @@ -82,6 +84,8 @@ public final class OpenapiServerFactory implements OpenapiStreamFactory
private final LongUnaryOperator supplyReplyId;
private final LongSupplier supplyTraceId;
private final LongFunction<CatalogHandler> supplyCatalog;
private final Consumer<NamespaceConfig> attachComposite;
private final Consumer<NamespaceConfig> detachComposite;
private final Long2ObjectHashMap<OpenapiBindingConfig> bindings;
private final int openapiTypeId;
private final int httpTypeId;
Expand All @@ -99,6 +103,8 @@ public OpenapiServerFactory(
this.supplyReplyId = context::supplyReplyId;
this.supplyTraceId = context::supplyTraceId;
this.supplyCatalog = context::supplyCatalog;
this.attachComposite = context::attachComposite;
this.detachComposite = context::detachComposite;
this.namespaceGenerator = new OpenapiServerNamespaceGenerator();
this.bindings = new Long2ObjectHashMap<>();
this.openapiTypeId = context.supplyTypeId(OpenapiBinding.NAME);
Expand All @@ -122,7 +128,7 @@ public void attach(
BindingConfig binding)
{
OpenapiBindingConfig openapiBinding = new OpenapiBindingConfig(binding, namespaceGenerator, supplyCatalog,
config.targetRouteId());
attachComposite, detachComposite, config.targetRouteId());
bindings.put(binding.id, openapiBinding);

openapiBinding.attach(binding);
Expand Down
Loading