Number Validator improvement to support OpenAPI & AsyncAPI specs #875
Conversation
| max: 1234.23 | ||
| min: -1234.94 | ||
| exclusiveMax: true | ||
| exclusiveMin: true |
There was a problem hiding this comment.
| max: 1234.23 | |
| min: -1234.94 | |
| exclusiveMax: true | |
| exclusiveMin: true | |
| range: (-1234.94,1234.23) |
Do you think using range with standard [ (inclusive) vs ( (exclusive) would be easier to read than 4 separate properties?
| { | ||
| "op": "add", | ||
| "path": "/$defs/types/enum/-", | ||
| "value": "double" | ||
| }, | ||
| { | ||
| "op": "add", | ||
| "path": "/$defs/converter/oneOf/1/allOf/-", |
There was a problem hiding this comment.
Let's review the structure of the schema for converters and validators, this doesn't look quite right to me.
Also we need to register for both converters and validators enums, agree?
| { | ||
| "type": "boolean", | ||
| "default": false | ||
| "type": "string" |
There was a problem hiding this comment.
We need a pattern for the string to validate syntax of the range format, agree?
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| public final class RangeConfigAdapter |
There was a problem hiding this comment.
The config adapter design pattern instantiates the adapter, and then calls adaptToJson and adaptFromJson as needed.
Let's follow the same pattern here, using adaptToString and adaptFromString instead.
| io.aklivity.zilla.runtime.model.core.internal.config.StringModelConfigAdapter; | ||
|
|
||
| provides io.aklivity.zilla.runtime.engine.model.ModelFactorySpi | ||
| with io.aklivity.zilla.runtime.model.core.internal.Int32ModelFactorySpi, | ||
| io.aklivity.zilla.runtime.model.core.internal.Int64ModelFactorySpi, | ||
| io.aklivity.zilla.runtime.model.core.internal.FloatModelFactorySpi, | ||
| io.aklivity.zilla.runtime.model.core.internal.DoubleModelFactorySpi, |
There was a problem hiding this comment.
Please list these provider implementations in alphabetical order.
| @@ -22,12 +22,14 @@ | |||
| with io.aklivity.zilla.runtime.model.core.internal.config.Int32ModelConfigAdapter, | |||
| io.aklivity.zilla.runtime.model.core.internal.config.Int64ModelConfigAdapter, | |||
| io.aklivity.zilla.runtime.model.core.internal.config.FloatModelConfigAdapter, | |||
| io.aklivity.zilla.runtime.model.core.internal.config.DoubleModelConfigAdapter, | |||
There was a problem hiding this comment.
Please list these provider implementations in alphabetical order.
| @@ -1,4 +1,5 @@ | |||
| io.aklivity.zilla.runtime.model.core.internal.config.Int32ModelConfigAdapter | |||
| io.aklivity.zilla.runtime.model.core.internal.config.Int64ModelConfigAdapter | |||
| io.aklivity.zilla.runtime.model.core.internal.config.FloatModelConfigAdapter | |||
| io.aklivity.zilla.runtime.model.core.internal.config.DoubleModelConfigAdapter | |||
There was a problem hiding this comment.
Please list these provider implementations in alphabetical order.
| @@ -1,4 +1,5 @@ | |||
| io.aklivity.zilla.runtime.model.core.internal.Int32ModelFactorySpi | |||
| io.aklivity.zilla.runtime.model.core.internal.Int64ModelFactorySpi | |||
| io.aklivity.zilla.runtime.model.core.internal.FloatModelFactorySpi | |||
| io.aklivity.zilla.runtime.model.core.internal.DoubleModelFactorySpi | |||
There was a problem hiding this comment.
Please list these provider implementations in alphabetical order.
No description provided.